Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new cookie store #34

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: new cookie store #34

wants to merge 1 commit into from

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented Jun 21, 2024

Implements a new CookieStore that:

  • Respects cookie domain and the response issuer origin;
  • Respects cookie path and the given request pathname (when returning relevant request cookies);
  • Has no persistence (use document.cookie and CookieStore.parse() in the browser instead).
  • Gets rid of the barrel export in index.ts.

Motivation

I feel like some of the functionality of this library is no longer relevant in MSW 2.0. I also feel like some of its functionality was a bit incorrect, like never taking the cookie's path into account in the .get() method. I also can't remember most of the intentions behind some of the methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant