Merge upstream/master #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joel Challis <[email protected]>
* Separate RGBLight/RGB Matrix keycode handling * Remove `_DISABLE_KEYCODES` handling * Update RGB Matrix keycode docs * Update underglow keycodes for previously migrated boards * Update keycodes for boards with custom handling * Fix typos * Fix bad merge
quantum: util: add bit and bitmask helpers These helpers are handy and can prevent off-by-one errors when working with registers and general low level bit manipulation tasks. The macros themself are inspired by the bits.h macros from the linux kernel source code. Signed-off-by: Stefan Kerkmann <[email protected]> Co-authored-by: Pascal Getreuer <[email protected]>
Co-authored-by: Joel Challis <[email protected]> Co-authored-by: jack <[email protected]> Co-authored-by: Ryan <[email protected]>
…ementations (qmk#24258) * usb_device_state: add idle_rate, led and protocol Previously all usb drivers and platform implementations (expect for our oddball atsam) tracked the same two global variables: - keyboard_protocol: to indicate if we are in report or boot protocol - keyboard_idle: for the idle_rate of the keyboard endpoint And a local variable that was exposed trough some indirection: - keyboard_led_state: for the currently set indicator leds (caps lock etc.) These have all been moved into the usb_device_state struct wich is accessible by getters and setters. This reduces code duplication and centralizes the state management across platforms and drivers. Signed-off-by: Stefan Kerkmann <[email protected]> * usb_device_state: reset protocol on reset The usb hid specification section 7.2.6 states: When initialized, all devices default to report protocol. However the host should not make any assumptions about the device’s state and should set the desired protocol whenever initializing a device. Thus on reset we should always do exactly that. Signed-off-by: Stefan Kerkmann <[email protected]> * keyboards: fix oversize warnings Signed-off-by: Stefan Kerkmann <[email protected]> --------- Signed-off-by: Stefan Kerkmann <[email protected]>
Update readme.md remove orphan layout
|
I've made some additional commits the last few days, mostly related to getting everything up-to-date with new JSON requirements. I also found a bug in QMK's implementation of EEPROM for STM32L[01]xx. For certain lower-end devices from the line-up (referred to as "Cat.1 devices" in their docs), only non-null writes to EEPROM are permitted for all write types except full word writes. I've made a fix that does word-aligned writes to remedy this. EDIT: Almost forgot: I also was able to get this working with L152 code with one small include_next tweak |
TinfoilSubmarine
force-pushed
the
anne_pro
branch
4 times, most recently
from
2ec2d0e to
df20384
Compare
TinfoilSubmarine
force-pushed
the
anne_pro
branch
10 times, most recently
from
90b0bf1 to
b0c879c
Compare
TinfoilSubmarine
force-pushed
the
anne_pro
branch
from
4b04213 to
7890972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for noise, but I think this may be a better option than rebasing the entire patchset.
I had to make a few updates to get it compiling. It still needs more work on the new JSON stuff, but it builds and works on my board.
Something must have been changed/fixed in chibios and EEPROM works now, so I also enabled that.