5829 load plugins via processor #6399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
…29-load-plugins-via-processor
andreievg
commented
Feb 3, 2025
| @@ -16,8 +16,9 @@ table! { | |||
| } | |||
| } | |||
|
|
|||
| // Database: https://github.com/openmsupply/open-msupply/blob/d6645711184c63593949c3e8b6dc96b5a5ded39f/server/repository/migrations/postgres/2022-02-11T15-00_create_key_value_store/up.sql#L2-L16 | |||
| // Snippet for adding new, including migration : https://github.com/msupply-foundation/open-msupply/wiki/Snippets "New Key Type for KeyValueStore" | |||
There was a problem hiding this comment.
Added a snippet for this, for future additions
andreievg
commented
Feb 3, 2025
| #[derive(DbEnum, Debug, Clone, PartialEq, Eq, Default)] | ||
| #[cfg_attr(test, derive(strum::EnumIter))] |
There was a problem hiding this comment.
This test wasn't stricly necessary, but was quick to add and doesn't add too much extra code, sorry to the reviewer
andreievg
commented
Feb 3, 2025
| @@ -147,11 +147,14 @@ pub async fn start_server( | |||
| } | |||
|
|
|||
| // PLUGIN CONTEXT | |||
|
|
|||
There was a problem hiding this comment.
Oops, sorry for format change
andreievg
commented
Feb 3, 2025
| } | ||
|
|
||
| ctx.processors_trigger |
There was a problem hiding this comment.
A trigger would work here, since rows have been upserted
andreievg
commented
Feb 3, 2025
|
|
||
| #[derive(Error, Debug)] | ||
| pub(crate) enum ProcessorError { | ||
| #[error("{0:?} not found: {1:?}")] | ||
| #[error("{0} not found: {1}")] |
There was a problem hiding this comment.
Chnaged error mapping, tehnically should just do [source] or from for existing error and they will be added to the error message without needing to print them out
andreievg
commented
Feb 3, 2025
| changelog.record_id.clone(), | ||
| ))?; | ||
|
|
||
| PluginInstance::bind(plugin); |
There was a problem hiding this comment.
Pretty simple processor to just just call 'bind'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5829
👩🏻💻 What does this PR do?
Adds a new processor to load plugins to plugin provider (so that after sync plugins are loaded without restart).
Plugins are also loaded at startup.
Added enum test, key_type_enum, to make sure key types in key value store match database type definitions
💌 Any notes for the reviewer?
🧪 Testing
Setup remote site and central site on this version. Sync them. Then run
cargo run --bin remote_server_cli -- generate-and-install-plugin-bundle -i './service/src/backend_plugin/examples/amc' -u 'http://localhost:8000' --username 'test' --password 'pass'
Above will upload plugin to central sever, after syncing remote site you should see AMC calculated per amc.js file. On servers restart you should still see AMC calculater as per amc.js file