Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5675.4 frontend #6390

Open
wants to merge 11 commits into
base: 5675.3-batch-create-IS-from-IO
Choose a base branch
from
Open

Conversation

roxy-dao
Copy link
Contributor

@roxy-dao roxy-dao commented Feb 3, 2025

Fixes #5675 & #6161

πŸ‘©πŸ»β€πŸ’» What does this PR do?

  • Adds split buttons for Inbound Shipment (Options are: Add item, Add from master list, Add from Internal Order)
    Screenshot 2025-02-03 at 2 23 39β€―PM
  • To add lines from Internal Order, the Internal Order:
    • Store pref: manually link supplier invoice to requisition
    • IS must be linked to an Internal Order (Go through steps from create invoice if pref is on)
  • Also fix split button not having shadow

πŸ§ͺ Testing

  • Follow 5675.2 link requisition modalΒ #6330 to create linked Inbound Shipment
  • Click on the split button and choose Add from Internal Order
  • Table should pop up with lines from that Internal Order
  • Select lines to add to IS
  • Click select
  • Lines should be added populated with: requested quantity = pack qty, pack size = 1
  • Note: Lines can be added multiple times.

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the v2.5.0 milestone Feb 3, 2025
@github-actions github-actions bot added bug Something is borken Build Tested: Passed Issue has been build tested with all tests passed. Team Ruru πŸ¦‰ Roxy, Ferg, Noel Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Tester: Alain Alain is testing this feature: CIV labels Feb 3, 2025
@github-actions github-actions bot modified the milestones: v2.5.0, v2.6.0 Feb 3, 2025
@github-actions github-actions bot added Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. feature: GEDSI UI tweaks labels Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Bundle size difference

Comparing this PR to main

Old size New size Diff
5.27 MB 5.27 MB 5.4 KB (0.10%)

Comment on lines +62 to +65
sx={{
boxShadow: theme => theme.shadows[2],
borderRadius: 24,
}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for GEDSI bug, adding shadow back to the split buttons

@@ -89,6 +97,7 @@ export const SplitButton = <T,>({
borderRadius: 0,
borderStartEndRadius: '24px',
borderEndEndRadius: '24px',
borderLeft: theme => `1px solid ${theme.palette.divider}`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To show that both parts of the button can be clicked

@roxy-dao roxy-dao removed Build Tested: Passed Issue has been build tested with all tests passed. Tester: Alain Alain is testing this Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken feature: CIV feature: GEDSI Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. Team Ruru πŸ¦‰ Roxy, Ferg, Noel UI tweaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GEDSI: some buttons on Android blur together with the background (missing shadow?)
1 participant