Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gaps csv & insert sql script #5968

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

jmbrunskill
Copy link
Contributor

Fixes #0000

πŸ‘©πŸ»β€πŸ’» What does this PR do?

@adamdewey has updated the master data spreadsheet to correctly calculate the unit volumes in the GAPS script.
This updates the SQL to use this new CSV and removed the incorrect calculation which didn't include doses.

πŸ’Œ Any notes for the reviewer?

The ordering has changed slightly in the csv which creates a big diff.
Maybe we should do some kind of sorting before exporting?

πŸ§ͺ Testing

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@jmbrunskill jmbrunskill requested a review from adamdewey January 9, 2025 04:37
elif packaging_level == 3:
volume_per_unit= float(row["DiluentTertiaryVolume"]) / 1000
volume_per_unit= float(row["DiluentTertiaryVolume"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only python change, the csv has been updated though with various changes...

@CarlosNZ
Copy link
Contributor

CarlosNZ commented Jan 9, 2025

@adamdewey -- can you let me know when you're happy with the functionality/correctness of this, and then I'll do a quick code review of it?

@jmbrunskill
Copy link
Contributor Author

jmbrunskill commented Jan 10, 2025

telegram-cloud-photo-size-1-4902717701554810427-y
need to rename that Master List to:

Name = β˜† GAPS reference catalogue
Description = Items used for Cold Chain Equipment Gap Analysis

@adamdewey
Copy link
Contributor

Still testing @CarlosNZ

@adamdewey
Copy link
Contributor

One comment, tidy up needed for Master List text:

Name = β˜† GAPS reference catalogue
Description = Items used for Cold Chain Equipment Gap Analysis

@adamdewey
Copy link
Contributor

Also seems like the cold storage types are not mapping correctly:

image

compared to the Master Data:

image

@jmbrunskill jmbrunskill requested a review from CarlosNZ January 29, 2025 01:21
@jmbrunskill
Copy link
Contributor Author

@adamdewey I've fixed that master list name typo. Can you confirm if anything else needs to be done or can we close this one out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants