-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gaps csv & insert sql script #5968
base: develop
Are you sure you want to change the base?
Conversation
elif packaging_level == 3: | ||
volume_per_unit= float(row["DiluentTertiaryVolume"]) / 1000 | ||
volume_per_unit= float(row["DiluentTertiaryVolume"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only python change, the csv has been updated though with various changes...
@adamdewey -- can you let me know when you're happy with the functionality/correctness of this, and then I'll do a quick code review of it? |
Still testing @CarlosNZ |
One comment, tidy up needed for Master List text: Name = |
@adamdewey I've fixed that master list name typo. Can you confirm if anything else needs to be done or can we close this one out? |
Fixes #0000
π©π»βπ» What does this PR do?
@adamdewey has updated the master data spreadsheet to correctly calculate the unit volumes in the GAPS script.
This updates the SQL to use this new CSV and removed the incorrect calculation which didn't include doses.
π Any notes for the reviewer?
The ordering has changed slightly in the csv which creates a big diff.
Maybe we should do some kind of sorting before exporting?
π§ͺ Testing
π Documentation
1.
2.