-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5750 civ 2.5 add item in page #5909
base: develop
Are you sure you want to change the base?
Conversation
Bundle size differenceComparing this PR to
|
client/packages/system/src/Item/Components/ListItems/ListItems.tsx
Outdated
Show resolved
Hide resolved
<InputWithLabelRow | ||
Input={ | ||
<NumericTextInput | ||
width={INPUT_WIDTH} | ||
value={draft?.outgoingUnits} | ||
value={draft?.itemStats.availableStockOnHand} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you summarise what you were changing here? Looks like you've added some fields... and hidden more things behind useConsumptionData
- what does that mean? lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no fields were added, they were just shifted since the stock autocomplete was added at the top~ and sorry, that's the wrong pref! It's supposed to be showExtraFields. Also the value was wrong (:
...ckages/requisitions/src/ResponseRequisition/DetailView/ResponseLineEdit/ResponseLineEdit.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just want to understand the other changes in the line edit files - let me know what you think of using the button instead!
Co-Authored-By: Laché Melvin <[email protected]>
Fixes #5750
👩🏻💻 What does this PR do?
Add item
button in Requisition and Internal Order to redirect to the line edit page where the user can add a new item to the requisitionNew item
at the bottom of the item list so users can add new items directly on the line edit page instead of having to go out and add new itemsNew item
option shouldn't be available if the Internal Order or Requisition is created from a program.🧪 Testing
Add item
button at the top right of the screenNew item
in the list on the left📃 Documentation
1.
2.