5162 response requisition indicator UI #5523
Conversation
github-actions
bot
added
enhancement
Cannot see it and causing errors in browser console
I couldn't replicate any so idk!
|
|
||
| const InputWithLabel = ({ data }: { data: IndicatorColumnNode }) => { | ||
| if (!data?.value) { | ||
| return; |
There was a problem hiding this comment.
Not sure if you were just returning here so the type is definitely available but... if no value on indicator yet then I get nothing!
There was a problem hiding this comment.
Probably should just pass through a default empty string if not defined...
There was a problem hiding this comment.
If the values don't exist for the indicator then the buttons or (tab if both indicators) shouldn't show!
There was a problem hiding this comment.
Alas we have determined this was actually because I had indicator lines with no values on an existing program requisition - works fine on newly created ones! Need to find a way to handle existing requisitions 🙏
| } | ||
| /> | ||
| )} | ||
| {hivIndicators.length > 0 && ( |
There was a problem hiding this comment.
Still seeing HIV indicators on my non-HIV program?
There was a problem hiding this comment.
Hmm I think if you look at an old program requisition, the button would still be there but if you click it everything gets filtered out? It's getting a bit gross cause I already do the same filter in IndicatorEditPage and IndicatorLineEdit, and I'd have to do it again in IndicatorTab. In hindsight I really should have persisted with doing it in the backend, as this will pop up as a problem request requisitions too.
As discussed I've also been ignoring that you can turn HIV off on program and the indicators will still be there 😭. I'm not 100% sure if OG does it, but ideally OG would set the HIV program_indicator to be inactive:
I don't believe we're doing any filtering on that yet but.
Dang yea, 'cause I did the filtering in the child routes/components but not IndicatorTab 🫠 . Really should do it in the backend so it's not so easily missed! |
Yeah, would like to see this as a clean up PR if poss - would be good to get the feature out to QA though? |
|
whoops just saw that hiv indicators could have the same issue, pushed quick fix for that too! |
| indicator => | ||
| indicator.code === 'REGIMEN' && | ||
| // Should only include regimen indicators if they have at least one column with a value | ||
| indicator.lineAndColumns.some(line => line.columns.some(c => c.value)) |
There was a problem hiding this comment.
coming from rust more recently I was like ugh I though js had an Array.any 😭. Been using filter and find hahahaaaaaaaa
|
Actually just tried setting a new HIV program back to non-HIV, and the indicators are gone so... must just be my munted dev data, sorry! |
Fixes #5162
👩🏻💻 What does this PR do?
Add indicator UI to manual customer program requisitions.
💌 Any notes for the reviewer?
For now we just have buttons to access each program indicator's lines. In the future it'll be tables for each as per designs.
Problems I've noticed that need fixing:
HIV indicators never seems to select first indicator line:
Probably a number input problem, but default value is typically
0. It is hard to actually remove this leading 0 without highlighting the digit and replacing it. This would feel even more awful on tablets:🧪 Testing
📃 Documentation
1.
2.