Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5354 Hide extra columns for general requisitions #5356

Conversation

roxy-dao
Copy link
Contributor

@roxy-dao roxy-dao commented Nov 7, 2024

Fixes #5354

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Extra columns don't show up for general requisitions only for program requisitions, so we can hide these already
Screenshot 2024-11-08 at 12 17 36β€―PM

πŸ§ͺ Testing

  • Have a general requisition
  • Don't see extra columns

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

Copy link

github-actions bot commented Nov 7, 2024

Bundle size difference

Comparing this PR to main

Old size New size Diff
4.97 MB 4.97 MB 80 B (0.00%)

@roxy-dao roxy-dao linked an issue Nov 7, 2024 that may be closed by this pull request
@github-actions github-actions bot added this to the V2.4.0 milestone Nov 7, 2024
@Chris-Petty Chris-Petty self-assigned this Nov 8, 2024
Copy link
Contributor

@Chris-Petty Chris-Petty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

Base automatically changed from 5345-Manual-reqs-Stock-on-hand-value-overwritten to develop November 10, 2024 22:38
@roxy-dao roxy-dao merged commit 3a50162 into develop Nov 10, 2024
3 checks passed
@roxy-dao roxy-dao deleted the 5354-Hide-extra-columns-if-Requisition-is-created-from-Internal-Order branch November 10, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide extra columns for general requisitions
2 participants