Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5137.4 #5322

Merged
merged 12 commits into from
Nov 10, 2024
Merged

5137.4 #5322

merged 12 commits into from
Nov 10, 2024

Conversation

roxy-dao
Copy link
Contributor

@roxy-dao roxy-dao commented Nov 5, 2024

Fixes #5137

πŸ‘©πŸ»β€πŸ’» What does this PR do?

Adds charts back to requisition page. Their store stats next to requested quantity and our store stats next to supply quantity

Screen.Recording.2024-11-06.at.11.12.52.AM.mov

πŸ§ͺ Testing

  • Create a manual requisition
  • Add lines
  • Shouldn't see icon next to requested
  • Click icon next to supply
  • See new bar chart
  • Create an automatic requisition (Through Internal Order)
  • Go to the receiving store
  • Click on requisition -> line
  • See icon next to requested
  • Click on requested chart icon (see stats)

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@@ -520,7 +520,6 @@
"label.age-months-count_other": "{{count}} months",
"label.age-years_one": "{{count}} year",
"label.age-years_other": "{{count}} years",
"label.all-requested-quantity": "Other requested",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed cause it's other-requested

Copy link

github-actions bot commented Nov 5, 2024

Bundle size difference

Comparing this PR to main

Old size New size Diff
4.95 MB 4.96 MB 10.36 KB (0.20%)

@Chris-Petty Chris-Petty self-assigned this Nov 6, 2024
Base automatically changed from 5137.3 to develop November 7, 2024 03:28
Copy link
Contributor

@Chris-Petty Chris-Petty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good and gave a test whirl πŸ‘

@roxy-dao roxy-dao merged commit fa61a22 into develop Nov 10, 2024
3 checks passed
@roxy-dao roxy-dao deleted the 5137.4 branch November 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requisition line edit + UI updates to line columns
2 participants