Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5177 allow user to create program manual requisitions #5220

Merged

Conversation

roxy-dao
Copy link
Contributor

@roxy-dao roxy-dao commented Oct 24, 2024

Fixes #5177

👩🏻‍💻 What does this PR do?

Allow users to create program response requisitions.

create.program.response.requisition.mov

🧪 Testing

  • Set up programs
  • Set tags for customers for those program master lists
  • Go to Requisition
  • Press New Requisition button
  • See program / general option to create a requisition
  • Go through options for program requisition
  • Click Create
  • Response requisition should be populated with master list lines for that program
  • Also you shouldn't see the program details in the toolbar anymore, they should show up in the side panel (Open by clicking More button

📃 Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the V2.4.0 milestone Oct 24, 2024
@github-actions github-actions bot added enhancement New feature or request front-end Front-end related Team Ruru 🦉 Roxy, Ferg, Noel feature: manual requisition labels Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

Bundle size difference

Comparing this PR to main

Old size New size Diff
4.88 MB 4.88 MB 0 B (0.00%)

@Chris-Petty Chris-Petty self-assigned this Oct 24, 2024
Copy link
Contributor

@Chris-Petty Chris-Petty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halfway! Gone deep on some react feedback and there some bugs to fix

@roxy-dao roxy-dao requested a review from Chris-Petty October 25, 2024 00:28
Copy link
Contributor

@Chris-Petty Chris-Petty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EEE i think revert the window resize commit and make an issue for it, otherwise looks mint!

@roxy-dao roxy-dao requested a review from Chris-Petty October 29, 2024 01:43
Copy link
Contributor

@Chris-Petty Chris-Petty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweeeeeet

@roxy-dao roxy-dao merged commit 3a9be8c into develop Oct 29, 2024
2 of 3 checks passed
@roxy-dao roxy-dao deleted the 5177-Allow-user-to-create-PROGRAM-manual-requisitions branch October 29, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: manual requisition front-end Front-end related Team Ruru 🦉 Roxy, Ferg, Noel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow user to create PROGRAM manual requisitions
2 participants