Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update report name translations #6385

Open
3 tasks
fergie-nz opened this issue Feb 2, 2025 · 0 comments
Open
3 tasks

Update report name translations #6385

fergie-nz opened this issue Feb 2, 2025 · 0 comments

Comments

@fergie-nz
Copy link
Contributor

Is your feature request related to a problem? Please describe 👀

A few things that would help report name translations to make them more useable.

Report name translations are currently done on the front end here: client/packages/reports/src/utils.ts
This replaces the report 'code' with a string which we translate in common.json.

This makes it slightly difficult to manage custom reports:

  • We are required to add custom report translation strings into the main OMS repo for specific clients
  • Doesn't allow for hard coding of report names in custom reports
  • Adds restrictions when a custom report is used to replace a standard report (ie only one translation per locale)
  • Translations and sub translation functions are conducted in more places than necessary.

Also side note is that this method is not documented which adds to confusion.

Describe the solution you'd like 🎁

  • Remove front end string manipulation
  • Translate based on 'name' rather than 'code'
  • Display 'name' translated without any conversions or simply display name.
    This would allow us to use report.standard-report as the name, or alternatively a hard coded string for standard reports

Describe alternatives you've considered 💭

Additional context 💌

Moneyworks Jobcode 🧰

OMS:CIRDV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant