Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispensing: Prescribed Quantity #6180

Open
5 tasks
Tracked by #6000
jmbrunskill opened this issue Jan 20, 2025 · 12 comments · May be fixed by #6345
Open
5 tasks
Tracked by #6000

Dispensing: Prescribed Quantity #6180

jmbrunskill opened this issue Jan 20, 2025 · 12 comments · May be fixed by #6345
Assignees
Labels
feature: dispensing Team Piwakawaka James, Carl, John, Zachariah
Milestone

Comments

@jmbrunskill
Copy link
Contributor

jmbrunskill commented Jan 20, 2025

Add Prescribed Quantity Prescription LineEditView

New field in the Line Edit View to record the prescribed quantity of the item (might be more than dispensed)

Notes

Need to figure out Where is this stored in mSupply?
Not 100% sure where this field shows up for editing? (probably next to the all Issue field? Under quantity)

This column is editable manually
This column doesn’t trigger any calculation
No need to to Implement the store preference for ‘edit prescribed quantity’

Acceptance Criteria 🧾

  • New Prescribed Quantity field in the Prescription Line Edit View
  • Field should sync to mSupply
  • Field should be editable while the prescription is not verified
  • No need to check if the field is valid, but must be a number
  • Display field in table in DetailView

Epic Link 🔗

#6000

Moneyworks Jobcode 🧰

OMS:CIDV

@mark-prins
Copy link
Collaborator

Stored in the [trans_line]prescribedQuantity column

@GeronimoJohn GeronimoJohn self-assigned this Jan 23, 2025
@jmbrunskill
Copy link
Contributor Author

@mark-prins do we need to record this if we have no stock at all for that item (e.g. Placeholder Line?)

@GeronimoJohn GeronimoJohn linked a pull request Jan 29, 2025 that will close this issue
7 tasks
@GeronimoJohn
Copy link
Contributor

Heya @mariyamsupply! Just wondering if we can get your thoughts on the Prescribed Quantity Input placement please

Image

@mariyamsupply
Copy link
Contributor

I think it'd make sense if we put 'Prescribed quantity' first, and then the 'Issue' input, with way more space in between.
'Issue' field could even be right aligned for this one (but not sure if that'd be consistent with the other screens without prescribed quantity.

ps. why do we have grey bg in the inputs? 👀

@jmbrunskill
Copy link
Contributor Author

Here's mSupply for Reference

Image

I think your solution would work @mariyamsupply if we then update the issue qty to the prescribed qty.
Then if there's not enough stock the issue would be set lower with the warning.

In the specs it explicitly says no logic, but I think this would be ok, @mark-prins do you agree?

In normal operations we want to make sure the first field is the one people need to fill in (prescribed Qty is optional).

@mariyamsupply
Copy link
Contributor

mariyamsupply commented Jan 30, 2025

I think if they asked for this field they want to fill it, and sequentially it makes sense to fill it first.
if not, that's okay too if it's just there empty.

and yes, when you enter prescribed quantity 20 we can auto-fill 'issue' with 20 too.
and if you change the 'issue', the prescribed quantity stays the same it was.
if it's not enough stock to issue, we show the info alert

@jmbrunskill
Copy link
Contributor Author

Thanks @mariyamsupply

Next question @mark-prins do we need to translate the Store Pref for usePrescribedQty, or is it ok to just have it turned on for everyone?

@mark-prins
Copy link
Collaborator

Store preference please 🙏

@jmbrunskill
Copy link
Contributor Author

Store preference please 🙏

#6354

@GeronimoJohn
Copy link
Contributor

@mariyamsupply thanks for that solution. How does the below feel like?

Screen.Recording.2025-01-31.at.11.14.29.AM.mov

Regarding the comment :
ps. why do we have grey bg in the inputs? 👀

Pretty sure this is happening due to the latest changes with Material UI. Will look into it sometime soon

@mariyamsupply
Copy link
Contributor

nice! Let's keep them closer tho :) Thanks!

@GeronimoJohn
Copy link
Contributor

Made it closer

Screen.Recording.2025-01-31.at.12.08.23.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: dispensing Team Piwakawaka James, Carl, John, Zachariah
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants