Error for not being able to add IO lines to IS

msupply-foundation · Feb 2, 2025 · 7e66c53 · 7e66c53
1 parent a059995
commit 7e66c53
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/...aphql/invoice_line/src/mutations/inbound_shipment_line/line/insert_from_internal_order.rs b/...aphql/invoice_line/src/mutations/inbound_shipment_line/line/insert_from_internal_order.rs
@@ -68,6 +68,7 @@ fn map_error(error: ServiceError) -> Result<InsertFromInternalOrderResponse> {
         | NotAnInboundShipment
         | RequisitionLineDoesNotExist
         | RequisitionNotLinkedToInvoice
+        | CannotAddLineFromInternalOrder
         | ItemDoesNotExist => StandardGraphqlError::BadUserInput(formatted_error),
         NewlyCreatedLineDoesNotExist | DatabaseError(_) => {
             StandardGraphqlError::InternalError(formatted_error)

diff --git a/server/service/src/invoice_line/inbound_shipment_from_internal_order_lines/mod.rs b/server/service/src/invoice_line/inbound_shipment_from_internal_order_lines/mod.rs
@@ -27,6 +27,7 @@ pub enum InsertFromInternalOrderLineError {
     RequisitionLineDoesNotExist,
     ItemDoesNotExist,
     RequisitionNotLinkedToInvoice,
+    CannotAddLineFromInternalOrder,
     NewlyCreatedLineDoesNotExist,
     DatabaseError(RepositoryError),
 }

diff --git a/server/service/src/invoice_line/inbound_shipment_from_internal_order_lines/validate.rs b/server/service/src/invoice_line/inbound_shipment_from_internal_order_lines/validate.rs
@@ -4,6 +4,7 @@ use crate::{
     invoice::{check_invoice_exists, check_invoice_is_editable, check_store},
     invoice_line::validate::check_item_exists,
     requisition_line::common::check_requisition_line_exists,
+    store_preference::get_store_preferences,
 };
 
 use super::{InsertFromInternalOrderLine, InsertFromInternalOrderLineError};
@@ -21,8 +22,15 @@ pub fn validate(
 ) -> Result<ValidateResults, InsertFromInternalOrderLineError> {
     use InsertFromInternalOrderLineError::*;
 
+    let store_preference = get_store_preferences(connection, store_id)?;
+
     let invoice =
         check_invoice_exists(&input.invoice_id, connection)?.ok_or(InvoiceDoesNotExist)?;
+    if !store_preference.manually_link_internal_order_to_inbound_shipment
+        || invoice.linked_invoice_id.is_some()
+    {
+        return Err(CannotAddLineFromInternalOrder);
+    }
 
     if !check_store(&invoice, store_id) {
         return Err(NotThisStoreInvoice);