Debug logging #323
Open
Debug logging #323
+97
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbrunskill
commented
Jan 14, 2025
| @@ -131,7 +131,9 @@ export function* tryProgramNewSensor({ | |||
| ); | |||
| ToastAndroid.show(`Connected and setup ${macAddress}`, ToastAndroid.SHORT); | |||
| } catch (e) { | |||
| yield put(ProgramAction.programNewSensorFail(macAddress, e?.toString())); | |||
| yield put( | |||
| ProgramAction.programNewSensorFail(macAddress, e?.toString() ?? 'FAILED TO PROGRAM SENSOR') | |||
There was a problem hiding this comment.
This is a side track but was giving me errors...
andreievg
reviewed
Jan 19, 2025
| @@ -123,6 +124,22 @@ export const DependencyContainer: FC = ({ children }) => { | |||
| })(); | |||
| }, []); | |||
|
|
|||
| useEffect(() => { | |||
There was a problem hiding this comment.
Above we are settings ready = true and we have all of the services available (without query to DependencyLocator), I think we should move this logic there
|
I would increase number of logs we keep: Debug-Logging...Debug-Logging(Increase-number-of-logs-we-keep) |
andreievg
approved these changes
Jan 19, 2025
There was a problem hiding this comment.
Looks great thanks, just some suggestions.
I think we should increase how much logs we are saving, especially once below takes place
Also to solve this issue (in another PR): #318, I think we need some raw data from:
<- log actual sensor logs we are savingdata, we could add automated test after that
I guess above would need to be under 'Debug' log levels ?
…e-number-of-logs-we-keep) Increase number of logs we keep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #322
I couldn't figure out a good pattern for enabling it on start up.
After various different attempts I've put it into the DependancyContainer.
Probably not the right place but figure if it's working, it's better then nothing?