Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#79 change application serial to string #80

Merged
merged 4 commits into from
Oct 19, 2020
Merged

#79 change application serial to string #80

merged 4 commits into from
Oct 19, 2020

Conversation

nmadruga
Copy link
Contributor

Required for Front-end PR of issue application-manager-web-app PR #31 -#33 (msupply-foundation/conforma-web-app#50)

CarlosNZ
CarlosNZ requested changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@CarlosNZ CarlosNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe constrain field to being UNIQUE?

database/buildSchema/16_application.sql Outdated Show resolved Hide resolved
@nmadruga
Copy link
Contributor Author

Maybe constrain field to being UNIQUE?

Yes. that's better. Thanks

@nmadruga nmadruga mentioned this pull request Oct 19, 2020
Merged
CarlosNZ
CarlosNZ approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@CarlosNZ CarlosNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nmadruga nmadruga merged commit a3f2e92 into master Oct 19, 2020
@nmadruga nmadruga deleted the #79-change-application-serial-to-string branch October 19, 2020 21:58
@nmadruga nmadruga linked an issue Oct 19, 2020 that may be closed by this pull request
Change database application.serialNumber to use string instead of int #79
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosNZ CarlosNZ CarlosNZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change database application.serialNumber to use string instead of int
2 participants
@nmadruga @CarlosNZ