Improve documentation organization, accuracy, and readability#754
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #754 +/- ##
==========================================
+ Coverage 64.29% 64.45% +0.16%
==========================================
Files 170 170
Lines 30655 30663 +8
Branches 2038 2038
==========================================
+ Hits 19709 19765 +56
+ Misses 10193 10145 -48
Partials 753 753 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I completed a preservation-first corrective review after identifying that the earlier readability pass removed too much beginner-oriented material. Corrective commits:
The review covered every changed documentation file. Material was restored unless it was demonstrably obsolete, incorrect, an unfinished placeholder, or replaced by a code-verified correction. Examples include restoring the full 913-line parallel-I/O chapter, the beginner error-handling philosophy, CRUD explanations, Docker port/mount/Jupyter guidance, virtual-cluster concepts and diagrams, GUI configuration explanations, and the original quick-start startup-output walkthrough. Final validation: a clean forced Sphinx HTML build rendered every page successfully. The only warnings were the two offline external intersphinx inventories; the ambiguous generated Review build: |
This file should not have been on github at all. It somehow got accidentally added to some commit and missed. It is incomplete and probably not a worth ever completing.
pavlis
left a comment
There was a problem hiding this comment.
I have some minor things I think should be resolved before we merge this, but the big picture is this fixes a lot more problems and mistakes than it creates. i.e. there are likely mistakes I missed, but it nothing compared to what it fixes.
@wangyinz look at the comments I left and consider implementing some of the minor changes I suggested. One thing I think I did but can't tell for sure is remove a file called "research_computing_essay.rst". That was something I started and decided to not include. It must have gotten pushed to the repository in error. Make sure it is removed with this pull request.
|
Addressed the human review feedback in
Validation: Python compilation and a runtime plain- |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 57 out of 57 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
python/mspasspy/db/normalize.py:677
- The docstring currently says
mspass_objectmust be one of the waveform types (TimeSeries/Seismogram/Ensembles), but the actual check isisinstance(mspass_object, Metadata), which also allows plainMetadata(and works because the waveform types inheritMetadata). Clarifying this in the docstring would make the contract consistent with the implementation.
Summary
mspass-dbmanagerremains valid for the sharded configurationelogcross-referenceWhy
The documentation had outdated commands, broken or incomplete API coverage, inconsistent navigation, and some deployment guidance that no longer matched the shipped configuration. A preservation/readability pass also found that several initial rewrites made first-run instructions unnecessarily intimidating, so those pages were simplified and the original approachable commands and list structure restored.
User impact
Users get clearer navigation, current deployment and data-management guidance, more complete API references, and shorter onboarding flows. Existing conceptual explanations, diagrams, examples, and important caveats are retained.
Validation
mspassConda environmentelogcross-reference warning eliminateddocker compose config --quietgit diff --checkLocal HTML output used for final review:
/tmp/mspass-docs-html-final-20260711/index.html.