Skip to content

Commit

Permalink
Resolve some comments by maintainer.
Browse files Browse the repository at this point in the history
  • Loading branch information
msiddhu committed Jul 11, 2024
1 parent 5db5c69 commit e610af4
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/clang-tidy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ jobs:
libgmock-dev \
libgtest-dev \
libbenchmark-dev
sudo -E ./ci/install_abseil.sh
sudo -E ./ci/setup_grpc.sh -m -p protobuf -p abseil-cpp
# sudo -E ./ci/install_abseil.sh
# sudo -E ./ci/setup_grpc.sh -m -p protobuf -p abseil-cpp


# WITH_OPENTRACING_SHIM and WITH_ETW is not present and will be excluded.
Expand All @@ -50,7 +50,6 @@ jobs:
-DWITH_OTLP_FILE=ON \
-DWITH_PROMETHEUS=ON \
-DWITH_ZIPKIN=ON \
-DWITH_ABSEIL=ON \
-DWITH_ELASTICSEARCH=ON \
-DWITH_OTLP_HTTP_COMPRESSION=ON \
-DWITH_EXAMPLES=ON \
Expand All @@ -59,9 +58,10 @@ jobs:
-DWITH_METRICS_EXEMPLAR_PREVIEW=ON \
-DWITH_ASYNC_EXPORT_PREVIEW=ON \
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-DWITH_OTLP_GRPC=ON \
-DWITH_OTLP_GRPC_SSL_MTLS_PREVIEW=ON \
-DCMAKE_CXX_CLANG_TIDY clang-tidy-18"
-DCMAKE_CXX_CLANG_TIDY clang-tidy-18
# -DWITH_ABSEIL=ON \
# -DWITH_OTLP_GRPC=ON \
# -DWITH_OTLP_GRPC_SSL_MTLS_PREVIEW=ON \
cd ..

# - name: Run Clang-Tidy
Expand Down

0 comments on commit e610af4

Please sign in to comment.