Interpolation Skymap Method #22
Conversation
There was a problem hiding this comment.
Thank you for your PR @CassandraAuri!
It will be very helpful if you implement the few things that I've suggested. It shouldn't be too difficult to implement.
I've left comments regrading custom_alt in the themis.py module only, but those minor edits should also be applied to the TREx and REGO loaders as well.
| If True, asilib will calculate (lat, lon) skymaps assuming a spherical Earth. Otherwise, it will use the official skymaps (Courtesy of University of Calgary). | ||
| custom_alt: str, default None | ||
| When selected, there are two options for skyma's between official sky maps: | ||
| If 'Geodetic', asilib will calculate (lat, lon) skymaps assuming a spherical Earth. Otherwise, it will use the official skymaps (Courtesy of University of Calgary). |
There was a problem hiding this comment.
Can you change 'Geodetic' to 'geodetic'? If I pass 'Geodetic' into this function it will raise an error.
|
|
||
| .. note:: | ||
|
|
||
| The spherical model of Earth's surface is less accurate than the oblate spheroid geometrical representation. Therefore, there will be a small difference between these and the official skymaps. | ||
|
|
||
| If 'Interp', asilib will calculate the (lat,lon) sky maps assuming that the interpolation between official maps is linear. This was supported by personal conversations with Dr. Eric Donovan of the University of Calgary |
There was a problem hiding this comment.
Same with changing 'Interp' lowercase. This should be also edited in the REGO and TREx functions.
| @matplotlib.testing.decorators.image_comparison( | ||
| baseline_images=['test_interp_skymap'], | ||
| tol=20, | ||
| remove_text=True, | ||
| extensions=['png'], | ||
| ) |
There was a problem hiding this comment.
| @matplotlib.testing.decorators.image_comparison( | |
| baseline_images=['test_interp_skymap'], | |
| tol=20, | |
| remove_text=True, | |
| extensions=['png'], | |
| ) |
|
Hey Mike, I will implement and fix this Wednesday, currently just running a bit behind on research. |
|
Havent forgotten about this, just crunch time. |
|
No worries, I also have half-made changes to asilib that I'm having trouble finishing. |
Co-authored-by: Mykhaylo Shumko <[email protected]>
Co-authored-by: Mykhaylo Shumko <[email protected]>
Co-authored-by: Mykhaylo Shumko <[email protected]>
PR summary
This pull request implements a new skymap method for "unofficial altitudes". During discussions during DASP, it was made known to me that the skymap's monotonically increase with height so a simple interpolation is all that is required to find intermediate skymap altitudes. In the skymap test we use the themsis skymap altitudes at 90km and 110km to perfectly recreate the 150km skymap (official).
PR checklist
CHANGELOG.mdand formatted.