[WIP] fix: make OpenAiProxyFactory closable
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davin111
reviewed
Jun 13, 2023
There was a problem hiding this comment.
Is there no need to implement close() for OpenAiApiClient, because spring WebClient does it in its own way?
I read this sentence in #25.
This did not happen when I used OpenAiApiClient defined in the spring boot starter that uses a spring webclient.
| response.body().close() | ||
| } | ||
| } catch (e: java.lang.Exception) { | ||
| // logger.warn("Failed to quietly close Response", e) |
|
@davin111 After doing some research, here is what I learned:
so instead of using this implementation, we could customize the OkhttpClient to use daemon threads for executors (After doing some research on whether there are other side effects) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #25