Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never make group title icons transparent #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

l0f3n
Copy link

@l0f3n l0f3n commented Jan 12, 2025

This fixes #9, at least for the mocha flavour. I havent really tested the others that much.

EDIT: Im not a designer, so this is possibly not the correct fix. Maybe it should be teal instead?

Summary by Sourcery

Bug Fixes:

  • Fix the transparency of group title icons.

Copy link

sourcery-ai bot commented Jan 12, 2025

Reviewer's Guide by Sourcery

This PR fixes an issue where group title icons were transparent in the Mocha theme, by setting the color of the icons to the surface1 color. It also applies the same fix to the Frappe, Latte, and Macchiato themes.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Set the group title icon color to surface1
  • Added a CSS rule to set the color of the i element within the h2 element of the main-section to var(--catppuccin-surface1)
flavours/catppuccin-frappe.css
flavours/catppuccin-latte.css
flavours/catppuccin-macchiato.css
flavours/catppuccin-mocha.css

Assessment against linked issues

Issue Objective Addressed Explanation
#9 Ensure section header icons are visible and correctly colored in both light and dark themes
#9 Prevent section header icons from becoming transparent in dark theme
#9 Maintain consistent icon styling across different Catppuccin color flavors

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @l0f3n - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please verify that this change works as expected across all theme flavors (frappe, latte, macchiato, and mocha) before merging.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Section header icons are not colored correctly
1 participant