Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section header icons are not colored correctly #9

Open
l0f3n opened this issue Jan 3, 2025 · 1 comment · May be fixed by #11
Open

Section header icons are not colored correctly #9

l0f3n opened this issue Jan 3, 2025 · 1 comment · May be fixed by #11
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@l0f3n
Copy link

l0f3n commented Jan 3, 2025

Using the light theme my page looks like this:
image

But using the dark theme it looks like this:
image

The fa-film icon next to the "Media" section header has disappeared. This is due to the dark theme which sets --highlight-primary to transparent, which the icon gets its color from. A simple fix would have been to set this to --catppuccin-teal, which is the color it should be. But this also changes the background color of the header:
image

This is a separate issue from #6, so Im creating a new one.

@l0f3n l0f3n changed the title Does color section header correctly Section header icons are not colored correctly Jan 3, 2025
@mrpbennett
Copy link
Owner

by all means if you want to try and fix it and provide a PR. I don't have time right now to fix this.

@mrpbennett mrpbennett added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants