fix: don't drop the Image twice per recycle - #169
Open
mrousavy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prepareForRecycle()callsonDisappear()/willHide()directly, but the view has already been removed from its window at that point, which fired the visibility callback and called it once already. So every recycle ranimageLoader.dropImage(..)twice.Harmless with the built-in
HybridImageLoader(it just nils the image), butdropImageis part of the publicHybridImageLoaderSpec- any third-party loader that refcounts, cancels, or releases a cache entry indropImagegets an unbalanced call.Fixed by tracking whether there is an outstanding request, making the drop idempotent. The direct call in
prepareForRecycle()is kept rather than removed, so we still drop correctly if a view is ever recycled while attached.Testing
Not verified on device - CI builds cover compilation.