chore: Import react-native version from ReactNativeVersion.h
#505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
mrousavy
changed the title
ReactNativeVersion.hReactNativeVersion.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the need of an extra step in
.podspec, andbuild.gradle/CMakeLists.txtfor the user.The extra step would've been a
node require.resolve("react-native/package.json")script, which could've caused problems with monorepos, node not being found, require not being resolved, and so on.This is now more solid - we import the ReactNativeVersion.h header from RN Core, and if it's not there we dont have react-native.
This now holds the true native RN version thanks to facebook/react-native#48813.