feat: Specify RN version as compiler flag #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
mrousavy
force-pushed
the
feat/react-native-flags
branch
from
f50e680 to
609945f
Compare
mrousavy
changed the title
|
Thank you for this @mrousavy 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifies
REACT_NATIVE_VERSIONas a compiler flag for both CocoaPods (iOS) and Gradle/CMake (Android) build flows. This holds the minor RN version, so e.g.76.Also, adds a flag called
HAS_REACT_NATIVEthat is only present if building in a React Native environment. If not, both flags will be absent.This can later be used to check if React Native views are supported. Or adopt for NativeScript compatibility (cc @NathanWalker)