Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace HybridObjectSpec (a protocol) with HybridObject (a base class) #486

Closed
wants to merge 6 commits into from

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Jan 12, 2025

In Swift, HybridObject is now a base class instead of a protocol.

Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
nitro-docs ⬜️ Skipped (Inspect) Jan 13, 2025 10:58am

@mrousavy
Copy link
Owner Author

ugh it doesnt work because if HybridMath (from MyNitroModule) extends HybridObject (from Nitro Core), it cannot resolve the base class because HybridObject is from a different clang module than HybridMath.

@mrousavy mrousavy closed this Jan 12, 2025
@mrousavy mrousavy reopened this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant