Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make NativeNitroModules a code-gen'd TurboModule again #144

Closed
wants to merge 5 commits into from

Conversation

mrousavy
Copy link
Owner

@mrousavy mrousavy commented Sep 23, 2024

This has two benefits:

  1. The app only builds if the NativeNitroModules spec is aligned with the TypeScript types
  2. The Java module now receives ReactApplicationContext

..but one potential minor downsides:

  1. There might be changes in CxxTurboModules in the future that could cause build issues with Nitro. Hopefully no breaking changes

@mrousavy
Copy link
Owner Author

ah, I forgot that we cannot do the same on Android. On Android, they expect the React Application's CMakeList.txt to compile my library's C++ code for whatever reason.

This complicates things as we cannot autolink or use prefabs anymore, so I can't go that route.

@mrousavy mrousavy marked this pull request as draft September 23, 2024 10:38
@mrousavy mrousavy closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant