fix: pass in generic types and export Specs #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The nitrogen page is a step by step guide on running Nitro Codegen but following as it is now leads user to errors.
When defining the Spec, HybridObject requires a generic parameter or else the user would get:
So this pr adds the generic type for guide completeness and exports the Spec since it is used in step 6 which I also made obvious in that step that this is the spec defined in .nitro.ts file.
Also the classes are missing the memorySize and hybridContext(for ios) for completeness. I copy pasted them, only to get a cryptic error in the console till i opened xcode. C++ needs to be updated too for memorySize? Not sure