fix: Fix name and get view

mrousavy · Jan 15, 2025 · ed79295 · ed79295
1 parent 8de491c
commit ed79295
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/packages/nitrogen/src/views/ViewComponentShadowNode.ts b/packages/nitrogen/src/views/ViewComponentShadowNode.ts
@@ -88,7 +88,7 @@ namespace ${namespace} {
   /**
    * The name of the actual native View.
    */
-  extern const char ${nameVariable}[] = "${name.HybridT}";
+  extern const char ${nameVariable}[] = "${name.T}";
 
   /**
    * Props for the "${spec.name}" View.

diff --git a/packages/nitrogen/src/views/swift/SwiftHybridViewManager.ts b/packages/nitrogen/src/views/swift/SwiftHybridViewManager.ts
@@ -72,15 +72,16 @@ using namespace ${namespace}::views;
   if (self = [super init]) {
     std::shared_ptr<${HybridTSpec}> hybridView = ${getHybridObjectConstructorCall(spec.name)}
     _hybridView = std::dynamic_pointer_cast<${HybridTSpecSwift}>(hybridView);
+    [self updateView];
   }
   return self;
 }
 
-- (UIView*) contentView {
+- (void) updateView {
   ${swiftNamespace}::${HybridTSpecCxx} swiftPart = _hybridView->getSwiftPart();
   void* viewUnsafe = swiftPart.getView();
   UIView* view = (__bridge_transfer UIView*) viewUnsafe;
-  return view;
+  [self setContentView:view];
 }
 
 - (void) updateProps:(const react::Props::Shared&)props

diff --git a/...ages/react-native-nitro-image/nitrogen/generated/ios/c++/views/HybridTestViewComponent.mm b/...ages/react-native-nitro-image/nitrogen/generated/ios/c++/views/HybridTestViewComponent.mm
@@ -45,15 +45,16 @@ - (instancetype) init {
   if (self = [super init]) {
     std::shared_ptr<HybridTestViewSpec> hybridView = NitroImage::NitroImageAutolinking::createTestView();
     _hybridView = std::dynamic_pointer_cast<HybridTestViewSpecSwift>(hybridView);
+    [self updateView];
   }
   return self;
 }
 
-- (UIView*) contentView {
+- (void) updateView {
   NitroImage::HybridTestViewSpec_cxx swiftPart = _hybridView->getSwiftPart();
   void* viewUnsafe = swiftPart.getView();
   UIView* view = (__bridge_transfer UIView*) viewUnsafe;
-  return view;
+  [self setContentView:view];
 }
 
 - (void) updateProps:(const react::Props::Shared&)props

diff --git a/.../react-native-nitro-image/nitrogen/generated/shared/c++/views/HybridTestViewComponent.hpp b/.../react-native-nitro-image/nitrogen/generated/shared/c++/views/HybridTestViewComponent.hpp
@@ -26,7 +26,7 @@ namespace margelo::nitro::image::views {
   /**
    * The name of the actual native View.
    */
-  extern const char HybridTestViewComponentName[] = "HybridTestView";
+  extern const char HybridTestViewComponentName[] = "TestView";
 
   /**
    * Props for the "TestView" View.