fix: Add hashString(string_view) equivalent

mrousavy · Jan 15, 2025 · 7d56961 · 7d56961
1 parent 94b823d
commit 7d56961
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/packages/nitrogen/src/views/ViewComponentShadowNode.ts b/packages/nitrogen/src/views/ViewComponentShadowNode.ts
@@ -173,7 +173,7 @@ namespace ${namespace} {
   }
 
   bool ${propsClassName}::filterObjectKeys(const std::string& propName) {
-    switch (hashString(propName.c_str())) {
+    switch (hashString(propName)) {
       ${indent(cases.join('\n'), '      ')}
       default: return false;
     }

diff --git a/packages/react-native-nitro-image/nitrogen/generated/shared/c++/views/TestViewComponent.cpp b/packages/react-native-nitro-image/nitrogen/generated/shared/c++/views/TestViewComponent.cpp
@@ -32,7 +32,7 @@ namespace margelo::nitro::image::views {
   }
 
   bool HybridTestViewProps::filterObjectKeys(const std::string& propName) {
-    switch (hashString(propName.c_str())) {
+    switch (hashString(propName)) {
       case hashString("someProp"): return true;
       case hashString("someCallback"): return true;
       default: return false;

diff --git a/packages/react-native-nitro-modules/cpp/utils/NitroHash.hpp b/packages/react-native-nitro-modules/cpp/utils/NitroHash.hpp
@@ -9,6 +9,7 @@
 
 #include <cstddef>
 #include <cstdint>
+#include <string>
 
 namespace margelo::nitro {
 
@@ -40,4 +41,8 @@ constexpr uint64_t hashString(const char (&str)[N]) {
   return hashString(str, N - 1); // N includes the null terminator, so subtract 1
 }
 
+inline uint64_t hashString(const std::string_view& string) {
+  return hashString(string.c_str(), string.length());
+}
+
 } // namespace margelo::nitro