fix: Use nativeOrder for ByteBuffer order

mrousavy · Sep 16, 2024 · 582eab0 · 582eab0
1 parent 05776c2
commit 582eab0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/react-native-nitro-modules/android/src/main/cpp/core/ByteBufferArrayBuffer.hpp b/packages/react-native-nitro-modules/android/src/main/cpp/core/ByteBufferArrayBuffer.hpp
@@ -21,7 +21,7 @@ using namespace facebook;
 class ByteBufferArrayBuffer final : public ArrayBuffer {
 public:
   explicit ByteBufferArrayBuffer(const jni::alias_ref<jni::JByteBuffer>& byteBuffer) : _byteBuffer(jni::make_global(byteBuffer)) {
-    _byteBuffer->order(jni::JByteOrder::bigEndian());
+    _byteBuffer->order(jni::JByteOrder::nativeOrder());
   }
 
 public:

diff --git a/packages/react-native-nitro-modules/android/src/main/cpp/core/JArrayBuffer.hpp b/packages/react-native-nitro-modules/android/src/main/cpp/core/JArrayBuffer.hpp
@@ -78,12 +78,12 @@ class JArrayBuffer final : public jni::HybridClass<JArrayBuffer> {
       size_t size = _arrayBuffer->size();
       if (copyIfNeeded) {
         auto buffer = jni::JByteBuffer::allocateDirect(size);
-        buffer->order(jni::JByteOrder::bigEndian());
+        buffer->order(jni::JByteOrder::nativeOrder());
         memcpy(buffer->getDirectAddress(), _arrayBuffer->data(), size);
         return buffer;
       } else {
         auto buffer = jni::JByteBuffer::wrapBytes(_arrayBuffer->data(), size);
-        buffer->order(jni::JByteOrder::bigEndian());
+        buffer->order(jni::JByteOrder::nativeOrder());
         return buffer;
       }
     }