fix: Mark Java HybridObjectRegistry as deprecated

HybridObjects should be registered from C++ instead.
mrousavy · Jan 13, 2025 · 4d2b1fe · 4d2b1fe
1 parent bbbeeaf
commit 4d2b1fe
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/packages/react-native-nitro-modules/android/src/main/cpp/registry/JHybridObjectRegistry.hpp b/packages/react-native-nitro-modules/android/src/main/cpp/registry/JHybridObjectRegistry.hpp
@@ -20,6 +20,7 @@ struct JHybridObjectRegistry : public jni::JavaClass<JHybridObjectRegistry> {
   static auto constexpr kJavaDescriptor = "Lcom/margelo/nitro/core/HybridObjectRegistry;";
 
 public:
+  [[deprecated("HybridObjects should be registered from C++ instead. Either autolink them using `nitro.json`, or add them manually in HybridObjectRegistry.")]]
   static void registerHybridObjectConstructor(jni::alias_ref<jni::JClass> clazz, std::string hybridObjectName,
                                               jni::alias_ref<JHybridObjectInitializer> constructorFn);
 

diff --git a/...tive-nitro-modules/android/src/main/java/com/margelo/nitro/core/HybridObjectRegistry.java b/...tive-nitro-modules/android/src/main/java/com/margelo/nitro/core/HybridObjectRegistry.java
@@ -20,6 +20,8 @@ public class HybridObjectRegistry {
      * Registers the given HybridObject in the `HybridObjectRegistry`.
      * It will be uniquely identified via it's `hybridObjectName`, and can be initialized from
      * JS using `NitroModules.createHybridObject<T>(name)` - which will call the `constructorFn` here.
+     * @deprecated HybridObjects should be registered from C++ instead. Either autolink them using `nitro.json`, or add them manually in HybridObjectRegistry.
      */
+    @Deprecated(forRemoval = true)
     public static native void registerHybridObjectConstructor(String hybridObjectName, HybridObjectInitializer initializer);
 }