fix: Tidy up the ctor and dtor

mrousavy · Sep 23, 2024 · 2b88306 · 2b88306
1 parent 3a71496
commit 2b88306
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/packages/react-native-nitro-modules/cpp/turbomodule/NativeNitroModules.cpp b/packages/react-native-nitro-modules/cpp/turbomodule/NativeNitroModules.cpp
@@ -19,8 +19,6 @@ using namespace margelo::nitro;
 NativeNitroModules::NativeNitroModules(std::shared_ptr<CallInvoker> jsInvoker)
     : TurboModule(kModuleName, jsInvoker), _callInvoker(jsInvoker) {}
 
-NativeNitroModules::~NativeNitroModules() {}
-
 jsi::Value NativeNitroModules::get(jsi::Runtime& runtime, const jsi::PropNameID& propName) {
   std::string name = propName.utf8(runtime);
 

diff --git a/packages/react-native-nitro-modules/cpp/turbomodule/NativeNitroModules.hpp b/packages/react-native-nitro-modules/cpp/turbomodule/NativeNitroModules.hpp
@@ -16,8 +16,7 @@ using namespace facebook;
 // The base C++-based TurboModule. This is the entry point where all nitro modules get initialized.
 class NativeNitroModules : public TurboModule {
 public:
-  NativeNitroModules(std::shared_ptr<CallInvoker> jsInvoker);
-  ~NativeNitroModules();
+  explicit NativeNitroModules(std::shared_ptr<CallInvoker> jsInvoker);
 
 public:
   jsi::Value get(jsi::Runtime& runtime, const jsi::PropNameID& propName) override;