fix: Better warning

mrousavy · Jan 13, 2025 · 27e1c9f · 27e1c9f
1 parent 3f6da93
commit 27e1c9f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/packages/react-native-nitro-modules/android/src/main/cpp/registry/JHybridObjectRegistry.hpp b/packages/react-native-nitro-modules/android/src/main/cpp/registry/JHybridObjectRegistry.hpp
@@ -21,7 +21,7 @@ struct JHybridObjectRegistry : public jni::JavaClass<JHybridObjectRegistry> {
 
 public:
   [[deprecated("HybridObjects should be registered from C++ instead. Either autolink them using `nitro.json`, "
-               "or add them manually in HybridObjectRegistry.")]]
+               "or add them manually in the C++ HybridObjectRegistry.")]]
   static void registerHybridObjectConstructor(jni::alias_ref<jni::JClass> clazz, std::string hybridObjectName,
                                               jni::alias_ref<JHybridObjectInitializer> constructorFn);
 

diff --git a/...e-nitro-modules/android/src/main/java/com/margelo/nitro/core/HybridObjectInitializer.java b/...e-nitro-modules/android/src/main/java/com/margelo/nitro/core/HybridObjectInitializer.java
@@ -4,8 +4,12 @@
 
 import com.facebook.proguard.annotations.DoNotStrip;
 
+/**
+ * @deprecated HybridObjects should be registered from C++ instead. Either autolink them using `nitro.json`, or add them manually in the C++ `HybridObjectRegistry`.
+ */
 @Keep
 @DoNotStrip
+@Deprecated(forRemoval = true)
 public interface HybridObjectInitializer {
     @Keep
     @DoNotStrip

diff --git a/...tive-nitro-modules/android/src/main/java/com/margelo/nitro/core/HybridObjectRegistry.java b/...tive-nitro-modules/android/src/main/java/com/margelo/nitro/core/HybridObjectRegistry.java
@@ -20,7 +20,7 @@ public class HybridObjectRegistry {
      * Registers the given HybridObject in the `HybridObjectRegistry`.
      * It will be uniquely identified via it's `hybridObjectName`, and can be initialized from
      * JS using `NitroModules.createHybridObject<T>(name)` - which will call the `constructorFn` here.
-     * @deprecated HybridObjects should be registered from C++ instead. Either autolink them using `nitro.json`, or add them manually in HybridObjectRegistry.
+     * @deprecated HybridObjects should be registered from C++ instead. Either autolink them using `nitro.json`, or add them manually in the C++ `HybridObjectRegistry`.
      */
     @Deprecated(forRemoval = true)
     public static native void registerHybridObjectConstructor(String hybridObjectName, HybridObjectInitializer initializer);