feat: Make memorySize optional in Kotlin as well (default = 0) (#472)

* feat: Make `memorySize` optional in Kotlin as well (default = 0) * fix: Remove it from other impls
mrousavy · Jan 9, 2025 · 0d6b836 · 0d6b836
1 parent 347fa02
commit 0d6b836
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 10 deletions.
diff --git a/...ages/react-native-nitro-image/android/src/main/java/com/margelo/nitro/image/HybridBase.kt b/...ages/react-native-nitro-image/android/src/main/java/com/margelo/nitro/image/HybridBase.kt
@@ -8,7 +8,4 @@ import com.facebook.proguard.annotations.DoNotStrip
 class HybridBase: HybridBaseSpec() {
     override val baseValue: Double
         get() = 10.0
-
-    override val memorySize: Long
-        get() = 0L
 }
diff --git a/...ges/react-native-nitro-image/android/src/main/java/com/margelo/nitro/image/HybridChild.kt b/...ges/react-native-nitro-image/android/src/main/java/com/margelo/nitro/image/HybridChild.kt
@@ -10,7 +10,4 @@ class HybridChild: HybridChildSpec() {
         get() = 20.0
     override val childValue: Double
         get() = 30.0
-
-    override val memorySize: Long
-        get() = 0L
 }
diff --git a/...ative-nitro-image/android/src/main/java/com/margelo/nitro/image/HybridTestObjectKotlin.kt b/...ative-nitro-image/android/src/main/java/com/margelo/nitro/image/HybridTestObjectKotlin.kt
@@ -298,7 +298,4 @@ class HybridTestObjectKotlin: HybridTestObjectSwiftKotlinSpec() {
     override fun newTestObject(): HybridTestObjectSwiftKotlinSpec {
         return HybridTestObjectKotlin()
     }
-
-    override val memorySize: Long
-        get() = 0L
 }
diff --git a/...s/react-native-nitro-modules/android/src/main/java/com/margelo/nitro/core/HybridObject.kt b/...s/react-native-nitro-modules/android/src/main/java/com/margelo/nitro/core/HybridObject.kt
@@ -32,7 +32,8 @@ abstract class HybridObject: ExtendableHybridClass {
      */
     @get:DoNotStrip
     @get:Keep
-    abstract val memorySize: Long
+    open val memorySize: Long
+        get() = 0L
 
     /**
      * Holds the native C++ instance.