New release #8
Open
New release #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some documentation improvements and added gh-pages target
This should be safer in the case of Lwt-wrapped exceptions
Lwt cleanup
Expose zscore.
Why: We should wait for `Lwt_unix.connect` call to finish before returning the file descriptor.
Why: Need to compile synchronous library without lwt available. This change addresses the need by: Remove `package(lwt/lwt.unix)` tags for source files which doesn't use lwt.
Why: As was mentioned in discussion for pr #26 the only way to avoid tricky tags is to split sync and lwt packages. Now we have three packages: `redis`, `redis.sync` and `redis.lwt`. * `redis` for common module types * `redis_sync/lwt` for concrete library implementation Also, this change will break backward compatability (in earlier versions, `Redis_sync` was a submodule of `Redis` and `Redis_lwt` was not).
Rework project structure
Support connections to Unix domain sockets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
22 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it be possible to have a new release? In the current opam version I think Redis_sync.IO does not have the same signature than in the online documentation.