Skip to content

Conversation

@travisbrady
Copy link

I have a use case for sorted sets (the Z_) commands and hyperloglogs (the PF_ commands) so I thought I'd add them.
Let me know what you think.

src/client.ml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: it's better to add spaces between the operator ::

@tovbinm
Copy link
Contributor

tovbinm commented Jul 23, 2014

LGTM

@travisbrady
Copy link
Author

Ok. Added the return_none, though I'll be honest I don't think it helps much and has nothing to do with zsets or hyperloglogs.

@travisbrady
Copy link
Author

Anything else needed to get this merged?

@tovbinm
Copy link
Contributor

tovbinm commented Aug 1, 2014

@mwells , can you please have a look?

@travisbrady
Copy link
Author

bump

@mwells
Copy link
Contributor

mwells commented Aug 12, 2014

Sorry, I let this drop. Will take a look tonight.

On Tue, Aug 12, 2014 at 9:08 AM, travisbrady [email protected]
wrote:

bump


Reply to this email directly or view it on GitHub
#7 (comment).

@mwells
Copy link
Contributor

mwells commented Aug 17, 2014

LGTM.

Thanks for adding these and sorry for the delay. The only problem is I don't have write access to the repo anymore, so I can't merge the pull request. I don't think @tovbinm does either.

Alternatively, I made a fork that I could keep maintaining. Want to send pull request there? I promise to be more timely.

j0sh pushed a commit to j0sh/ocaml-redis that referenced this pull request Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants