-
Notifications
You must be signed in to change notification settings - Fork 43
Added commands for sorted sets and hyperloglogs #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/client.ml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: it's better to add spaces between the operator ::
|
LGTM |
|
Ok. Added the return_none, though I'll be honest I don't think it helps much and has nothing to do with zsets or hyperloglogs. |
|
Anything else needed to get this merged? |
|
@mwells , can you please have a look? |
|
bump |
|
Sorry, I let this drop. Will take a look tonight. On Tue, Aug 12, 2014 at 9:08 AM, travisbrady [email protected]
|
|
LGTM. Thanks for adding these and sorry for the delay. The only problem is I don't have write access to the repo anymore, so I can't merge the pull request. I don't think @tovbinm does either. Alternatively, I made a fork that I could keep maintaining. Want to send pull request there? I promise to be more timely. |
Remove Batteries
I have a use case for sorted sets (the Z_) commands and hyperloglogs (the PF_ commands) so I thought I'd add them.
Let me know what you think.