Fix missing order_by in task and student list
#638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
force-pushed
the
fix-task-ordering
branch
from
4e7dc22 to
446e1e1
Compare
geordi
reviewed
Mar 18, 2025
Kobzol
force-pushed
the
fix-task-ordering
branch
from
446e1e1 to
cb28446
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the good news is that this was easy to fix. The bad news is that it was broken even before we broke it recently =D The autocomplete tries to download all tasks from Kelvin (there are more than 3 thousand tasks at the moment), which is really not a good idea, and will not work.. It either needs to be reimplemented or we should remove it completely.
At the very least, it should only download tasks from the given subject. I will do that in a follow-up PR.
Related issue: #637