Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segvs #178

Merged
merged 3 commits into from
May 24, 2024
Merged

Fix segvs #178

merged 3 commits into from
May 24, 2024

Conversation

mrkn
Copy link
Owner

@mrkn mrkn commented May 24, 2024 •
edited
Loading

This patch fixes the following SEGVs.

  1. SEGV on PyPtr finalizer that is called on non-main threads due to GC sweeper
  2. SEGV on Ruby process finalization phase

@mrkn mrkn changed the title Fix segv on PyPtr finalizer Fix segvs May 24, 2024
mrkn added 3 commits May 24, 2024 14:40
@mrkn
Fix use of CALL_WITH_GVL
cf15233
@mrkn
Fix SEGV on Ruby finalization phase
b84a2be
@mrkn
Ensure GIL state in pycall_pyptr_free
0702618 
This needs because this function may be called from GC sweeper on non-main threads.
@mrkn mrkn merged commit 22629fd into master May 24, 2024
26 of 35 checks passed
@mrkn mrkn deleted the fix_segv branch May 24, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mrkn