Buffers of 16 or multiple of 16 bytes are not fully processed by hot …

…loop (off by one in check)
mrhooray · Feb 23, 2023 · 76a053b · 76a053b
1 parent 007687a
commit 76a053b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/src/crc128.rs b/src/crc128.rs
@@ -77,7 +77,7 @@ const fn update_slice16(
     let mut i = 0;
     let len = bytes.len();
     if reflect {
-        while i + 16 < len {
+        while i + 16 <= len {
             assert!((i + 15) < len);
 
             let current0 = bytes[i] ^ crc as u8;
@@ -123,7 +123,7 @@ const fn update_slice16(
             i += 1;
         }
     } else {
-        while i + 16 < len {
+        while i + 16 <= len {
             assert!((i + 15) < len);
 
             let current0 = bytes[i] ^ (crc >> 120) as u8;

diff --git a/src/crc16.rs b/src/crc16.rs
@@ -75,8 +75,9 @@ const fn update_slice16(
 ) -> u16 {
     let len = bytes.len();
     let mut i = 0;
+
     if reflect {
-        while i + 16 < len {
+        while i + 16 <= len {
             assert!((i + 15) < len);
 
             let current0 = bytes[i] ^ (crc as u8);
@@ -108,7 +109,7 @@ const fn update_slice16(
             i += 1;
         }
     } else {
-        while i + 16 < len {
+        while i + 16 <= len {
             assert!((i + 15) < len);
 
             let current0 = bytes[i] ^ ((crc >> 8) as u8);

diff --git a/src/crc64.rs b/src/crc64.rs
@@ -78,7 +78,7 @@ const fn update_slice16(
     let mut i = 0;
     let len = bytes.len();
     if reflect {
-        while i + 16 < len {
+        while i + 16 <= len {
             assert!((i + 15) < len);
 
             let current0 = bytes[i] ^ crc as u8;
@@ -116,7 +116,7 @@ const fn update_slice16(
             i += 1;
         }
     } else {
-        while i + 16 < len {
+        while i + 16 <= len {
             assert!((i + 15) < len);
 
             let current0 = bytes[i] ^ (crc >> 56) as u8;

diff --git a/src/crc8.rs b/src/crc8.rs
@@ -57,7 +57,7 @@ const fn update_slice16(mut crc: u8, table: &[[u8; 256]; 16], bytes: &[u8]) -> u
     let len = bytes.len();
     let mut i = 0;
 
-    while i + 16 < len {
+    while i + 16 <= len {
         assert!((i + 15) < len);
 
         crc = table[0][bytes[i + 15] as usize]