Fix SWB pull oracle program id #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
in 0.1.14 of This will be needed for me in devnet 👍
|
jkbpvsc
approved these changes
Aug 19, 2024
jkbpvsc
added a commit
that referenced
this pull request
Oct 15, 2024
* Was incorrectly using V2 (switchboard_on_demand::SWITCHBOARD_PROGRAM_ID) instead of on_demand (switchboard_on_demand::SWITCHBOARD_ON_DEMAND_PROGRAM_ID), now hardcoded in local constants to avoid ambiguity. * Fixes CI config so unit tests can run again. --------- Co-authored-by: J <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was incorrectly using V2 (
switchboard_on_demand::SWITCHBOARD_PROGRAM_ID) instead of on_demand (switchboard_on_demand::SWITCHBOARD_ON_DEMAND_PROGRAM_ID), now hardcoded in local constants to avoid ambiguity.Fixes CI config so unit tests can run again.
Note: using
switchboard_on_demand::SWITCHBOARD_ON_DEMAND_PROGRAM_IDcan cause the program to silently fail to build (likely from lazy static) and throwprogram is not deployedin testing.