Skip to content

Commit

Permalink
Merge pull request #286 from mreishus/add/compile-without-warnings
Browse files Browse the repository at this point in the history
Change github ci/cd to use mix compile --warnings-as-errors
  • Loading branch information
mreishus authored Nov 23, 2023
2 parents 67e40e5 + 0fa0159 commit a312149
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/elixir.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,11 +102,8 @@ jobs:
# Step: Compile the project treating any warnings as errors.
# Customize this step if a different behavior is desired.

# - name: Compiles without warnings
# run: mix compile --warnings-as-errors

- name: Compiles
run: mix compile
- name: Compiles without warnings
run: mix compile --warnings-as-errors

# Step: Check that the checked in code has already been formatted.
# This step fails if something was found unformatted.
Expand Down
2 changes: 1 addition & 1 deletion apps/demon_spirit_web/test/support/conn_case.ex
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ defmodule DemonSpiritWeb.ConnCase do
end
end

setup tags do
setup _tags do
# :ok = Ecto.Adapters.SQL.Sandbox.checkout(DemonSpirit.Repo)

# unless tags[:async] do
Expand Down
2 changes: 1 addition & 1 deletion config/test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ config :demon_spirit_web, DemonSpiritWeb.Endpoint,
server: false

# Print only warnings and errors during test
config :logger, level: :warn
config :logger, level: :warning

0 comments on commit a312149

Please sign in to comment.