WebGPURenderer: Introduce RenderTarget3D and RenderTargetArray #30155
+555
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ix clear in webgpubackend
RenaudRohlinger
commented
Dec 20, 2024
|
|
||
| if ( color ) { | ||
|
|
||
| for ( const texture of renderTargetData.textures ) { | ||
| const descriptor = this._getRenderPassDescriptor( renderTargetContext ); |
There was a problem hiding this comment.
@sunag FYI here I updated the RenderContext to support RenderTarget that has not been rendered yet.
This way this prevent issues where the clear Pass doesn't match the correct descriptor associated to a texture and reuse how we setup a descriptor with _getRenderPassDescriptor which also makes the code cleaner.
|
Maybe |
sunag
reviewed
Dec 21, 2024
Mugen87
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce support for 3D textures and texture arrays in multi-render target (MRT) setups for both WebGPU and WebGL backends.
Unlike WebGLRenderer I used prefix instead of suffix (
WebGLArrayRenderTarget->RenderTargetArray) as a3DRenderTargetfelt wrong.Made a example while working on it that displays 4 meshes:
Each slice of both RenderTarget is incremented and rendered every 50ms.
This contribution is funded by Utsubo