-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSL: SubgroupFunctionNode #30022
base: dev
Are you sure you want to change the base?
TSL: SubgroupFunctionNode #30022
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
import TempNode from '../core/TempNode.js'; | ||
import { addMethodChaining, nodeProxy } from '../tsl/TSLCore.js'; | ||
|
||
class SubgroupFunctionNode extends TempNode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding JSDoc for SubgroupFunctionNode
?
For new modules, we should add documentation right from the beginning. Use FunctionNode
as an orientation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the class, how about this:
This class represents a set of built in WGSL shader functions that synchronously execute an operation across a subgroup, or 'wave', of compute or fragment shader invocations within a workgroup. Typically, these functions will synchronously execute an operation using data from all active invocations within the subgroup, then broadcast that result to all active invocations. In other graphics APIs, subgroup functions are also referred to as wave intrinsics (DirectX/HLSL) or warp intrinsics (CUDA).
890d56f
to
62fc41a
Compare
62fc41a
to
890d56f
Compare
It would be important if we had an example using this feature, just to be sure that this feature will be working release after release. |
Working on it 👍. Been busy with work. |
Related issue: #XXXX
Description
Adds basic wave intrinsic/subgroup function support to TSL. Function definitions are derived from this link:
https://github.com/gpuweb/gpuweb/blob/main/proposals/subgroups.md.