Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for images (WebKit) #3

Closed
wants to merge 1 commit into from
Closed

Support for images (WebKit) #3

wants to merge 1 commit into from

Conversation

nevir
Copy link

@nevir nevir commented Feb 13, 2013

The trick is to add content: "" to the image its self

@nevir
Copy link
Author

nevir commented Feb 13, 2013

Oh, ha, damn - I'm not the first! This should close #2

@fvsch
Copy link

fvsch commented Feb 13, 2013

I’m not sure how browser support has evolved in the past year, but this is something I briefly discussed last year here: fvsch/remarkdown#1

@nevir, you wrote “images work (in most browsers)”, could you elaborate on what rendering engines your code works with?

@nevir
Copy link
Author

nevir commented Feb 13, 2013

@fvsch apparently just WebKit. The visibility: hidden/visibility: visible approach you're taking doesn't appear to be working in Firefox any more (v18) :(

@mrcoles
Copy link
Owner

mrcoles commented Feb 16, 2013

change it so this shows up when there's the class markdown-img, and I’ll merge this in. I’d rather something that’s a little more cross-browser before making it a default.

Here’s an example of where markdown.less has another optional class markdown-ones (I caved on the numbering) e56bd92#L2R216

@nevir
Copy link
Author

nevir commented Aug 12, 2022

Killing off some of my really old PRs

@nevir nevir closed this Aug 12, 2022
@nevir nevir deleted the images branch August 12, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants