Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: email with dashes are now considered valid #58

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: email with dashes are now considered valid #58

merged 1 commit into from
Jan 3, 2024

Commits on Jan 3, 2024

  1. fix: email with dashes are now considered valid 

    Why:

- Email addresses with dashes ("-") were considered invalid

How:

- Use a more general regex to validate email address in email_chk(). Stop using a-z0-9
  to denote alphanumeric pattern but use [:alnum:] which might have
  helped avoid conflict with - in the pattern range []
- Start using {testthat} to include a basic test for the email_chk()
  function

Closes issue mrchypark#57
    @ALanguillaume
    ALanguillaume committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d4e6435 View commit details
    Browse the repository at this point in the history