fix integration tests #243
Conversation
c-cube
force-pushed
the
simon/fix-integration-tests
branch
from
2b40153
to
c15fc69
Compare
| @@ -1,3 +1,5 @@ | |||
| (env | |||
| (_ | |||
| (flags :standard -warn-error -a+8 -w +a-4-40-41-42-44-48-70))) | |||
|
|
|||
| (data_only_dirs runtime-bs) | |||
There was a problem hiding this comment.
Maybe we could just drop it altogether?
There was a problem hiding this comment.
Maybe, it doesn't cost much right now, idk. I'm not sure how to inquire about the existence of current users?
There was a problem hiding this comment.
How is commenting it out via data_only_dirs different from just removing? Git has history in place in case it needs to be resurrected - it would be trivial to do so... Not sure about how to inquire about the existence of current users. We can probably find out who introduced that part of the codebase and check with them?
|
Fair enough, I guess we can remove it. The old package will be there, we
just don't support it in the next major release?
|
c-cube
force-pushed
the
simon/fix-integration-tests
branch
from
30bdbc8
to
45a3e21
Compare
Yeah, sounds like a plan |
|
Ah damn, I remember now, I got stuck on fixing the CI because the google files are not there 😢 : https://github.com/mransan/ocaml-protoc/actions/runs/9419796009/job/25950383987#step:11:41 |
|
We're bundling them into our fork of ocaml protoc binary, and they get
automagically included when referenced. We use ppx_blob to do the job.
…On Fri, Jun 7, 2024, 20:41 Simon Cruanes ***@***.***> wrote:
Ah damn, I remember now, I got stuck on fixing the CI because the google
files are not there 😢 :
https://github.com/mransan/ocaml-protoc/actions/runs/9419796009/job/25950383987#step:11:41
—
Reply to this email directly, view it on GitHub
<#243 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZXBHMEB734YAPDAFBAWTZGHPEZAVCNFSM6AAAAABFQ76J56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGE4DCNRYGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Maybe we can vendor them just for CI purposes, here? |
c-cube
force-pushed
the
simon/fix-integration-tests
branch
from
f2e90ac
to
9672ed0
Compare
|
ALRIGHT IT BUILDS!!! 😵💫 |
Sounds like CI pain 😁 |
|
ahah yeah, I moved some stuff to docker so I could run it locally first 😂 . I think we're getting in better shape for 4.0! |
these tests need updating after the changes in how single-oneof messages are translated.