Namespacing local variables to prevent collision with environment. #5
Conversation
|
I think #8 might be a better implementation of this |
|
@mrako , can you please process this merge request if you agree with the changes. |
|
#8 is not a better fix, because as far as I can tell, it still allows modification of generally-named env vars in the global scope, for the duration of the script's execution. If some other process relies on Port or Host during that tim, you will still get issues. These var names are way too common to let them be touched in such script |
|
My comment is related to changes included in this pull request. It seems the file changed shows that generally-named env vars are taken care of in https://github.com/mrako/wait-for/pull/5/files |
|
Hello! Sorry for lagging... Can you take a look at eficode/wait-for? It is still maintained. I will update this branch once you confirm. |
See: #4