ao/avfoundation: fix memory leak #16355
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Download the artifacts for this pull request: Windows |
|
@ruihe774 if you have some free time, could you possible look at this please? i will try to have a look at the weekend at the earliest. |
|
Sure.
Get Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: der richter ***@***.***>
Sent: Tuesday, May 20, 2025 5:17:56 AM
To: mpv-player/mpv ***@***.***>
Cc: Rui He ***@***.***>; Mention ***@***.***>
Subject: Re: [mpv-player/mpv] ao/avfoundation: fix memory leak (PR #16355)
[https://avatars.githubusercontent.com/u/680386?s=20&v=4]Akemi left a comment (mpv-player/mpv#16355)<#16355 (comment)>
@ruihe774<https://github.com/ruihe774> if you have some free time, could you possible look at this please?
i will try to have a look at the weekend at the earliest.
―
Reply to this email directly, view it on GitHub<#16355 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4GNBY7OMT2BOZDDV7ZW2JD27JDAJAVCNFSM6AAAAAB5K4WT7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOJSGI4DEOJYGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ruihe774
approved these changes
May 30, 2025
|
instead of merging master into your branch, you need to rebase your branch. otherwise we can't cleanly merge it. let me know if you have trouble with that. |
|
In fact, I think you don’t have to do anything; I believe Git can handle merging without manual intervention.
…________________________________
From: der richter ***@***.***>
Sent: Sunday, June 1, 2025 6:33:08 PM
To: mpv-player/mpv ***@***.***>
Cc: Rui He ***@***.***>; Mention ***@***.***>
Subject: Re: [mpv-player/mpv] ao/avfoundation: fix memory leak (PR #16355)
[https://avatars.githubusercontent.com/u/680386?s=20&v=4]Akemi left a comment (mpv-player/mpv#16355)<#16355 (comment)>
instead of merging master into your branch, you need to rebase your branch. otherwise we can't cleanly merge it. let me know if you have trouble with that.
―
Reply to this email directly, view it on GitHub<#16355 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4GNBY4MIJYJI3P4FJV7YJD3BLJGJAVCNFSM6AAAAAB5K4WT7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSMRWHE4TCOBRG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
you probably didn't see it, but before the recent force push (right before your comment) and my previous comment, there were 3 'stray' "marge master into ..." commits. see 94f0eee from the force push. |
Fix memory leak in ao_avfoundation caused by audio device switching mpv-player#16283
|
@Akemi do I need to do anything else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak in ao_avfoundation caused by audio device switching #16283