Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats.lua: only reprint stats on video-reconfig when toggled #15545

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guidocella
Copy link
Contributor

Make this behave like the comment says it should, because currently when you show oneshot stats and change file, stats are printed again and hide --osd-playing-msg. This happens even if you hide the stats by show-texting something else and change file before the timer expires.

Make this behave like the comment says it should, because currently when
you show oneshot stats and change file, stats are printed again and hide
--osd-playing-msg. This happens even if you hide the stats by
show-texting something else and change file before the timer expires.
Copy link

Download the artifacts for this pull request:

Windows
macOS

@Dudemanguy
Copy link
Member

Isn't it more desirable that the stats do update when the file changes here?

@guidocella
Copy link
Contributor Author

They do update when toggled. stats never update automatically in oneshot mode otherwise and they disappear too quickly to read the new file's info anyway, it just annoyingly overwrites --osd-playing-msg with no way to bring it back.

@Dudemanguy
Copy link
Member

Dudemanguy commented Dec 20, 2024

The oneshot mode just says it's a fixed duration in the manual.

they disappear too quickly to read the new file's info anyway

I don't agree. With just some leisurely keyboard presses (i, >), much of the updated stats I can easily read before it disappears.

@guidocella
Copy link
Contributor Author

I mean redraw_delay does not apply in oneshot mode, stats are calculated once and are not supposed to refresh. Redrawing on video-reconfig even makes them redraw if they've already been hidden by a different OSD message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants