{select,osc}.lua: add a miscellaneous menu #15499
Open
+90
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasper93
reviewed
Dec 12, 2024
| @@ -427,3 +427,29 @@ mp.add_key_binding(nil, "show-properties", function () | |||
| end, | |||
| }) | |||
| end) | |||
|
|
|||
| mp.add_key_binding(nil, "menu", function () | |||
| local menu = { | |||
There was a problem hiding this comment.
Shouldn't this list all select? Especially why vid select is hidden?
There was a problem hiding this comment.
Because I saw uosc doesn't have it so I didn't if it's worth adding.
There was a problem hiding this comment.
Because I saw uosc doesn't have it so I didn't if it's worth adding.
Of course they has it. In UOSC each button is dynamic and show only when needed. See https://github.com/tomasklaen/uosc/blob/6a1c0e9c6e7e9e43cda1c1ea3e44a911fae45927/src/uosc.conf#L83C1-L83C211 specifically, <has_many_video>video.
This menu could do this too, to not show items that goes nowhere.
|
Download the artifacts for this pull request: |
guidocella
force-pushed
the
menu
branch
6 times, most recently
from
0a415cb to
b6e1d02
Compare
Add a generic menu to bar layouts to provide discoverability for the select menus to users who don't realize you can right click OSC buttons. There's no space to add it in box layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a generic menu to bar layouts to provide discoverability for the select menus to users who don't realize you can right click OSC buttons.
There's no space to add it in box layout.
We just gotta figure out how to add a proper icon instead of ☰. Maybe we can extract this from Symbola like in db3754d. Also we could add more entries later like Open file or Edit config file.